New Adapter: MadSense #4169

madsenseops · 2025-01-21T09:19:51Z

github-actions · 2025-01-21T09:20:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c6dc0a9

madsense

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:28:	MakeRequests		89.5%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:61:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:89:	getEndpointURL		100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:95:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:13:	parseImpExt		75.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:33:	getHeaders		88.2%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:64:	getTypedBidFromBid	90.9%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:87:	getMediaTypeForBid	75.0%
total:									(statements)		85.1%

bsardo · 2025-01-22T19:35:27Z

@pm-jaydeep-mohite can you please review?

pm-jaydeep-mohite · 2025-01-30T05:01:39Z

static/bidder-info/madsense.yaml

@@ -0,0 +1,12 @@
+endpoint: "https://ads.madsense.io/pbs"


Endpoint is reachable
curl -i --location --request POST https://ads.madsense.io/pbs
HTTP/2 200
content-length: 0

pm-jaydeep-mohite · 2025-01-30T07:17:21Z

adapters/madsense/utils.go

+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo, nil
+	default:


UT can be added to cover default case

added UT for default case

pm-jaydeep-mohite · 2025-01-30T08:05:27Z

adapters/madsense/madsense.go

+				bidErrors = append(bidErrors, err)
+				continue
+			}
+


Nitpick: Remove blank line

pm-jaydeep-mohite · 2025-01-30T08:10:11Z

adapters/madsense/utils.go

+	"fmt"
+	"github.com/prebid/openrtb/v20/openrtb2"
+	"github.com/prebid/prebid-server/v3/adapters"
+	"github.com/prebid/prebid-server/v3/errortypes"
+	"github.com/prebid/prebid-server/v3/openrtb_ext"
+	"github.com/prebid/prebid-server/v3/util/jsonutil"
+	"net/http"


Can be re-ordered as

` "fmt" "net/http" "github.com/prebid/openrtb/v20/openrtb2" "github.com/prebid/prebid-server/v3/adapters" "github.com/prebid/prebid-server/v3/errortypes" "github.com/prebid/prebid-server/v3/openrtb_ext" "github.com/prebid/prebid-server/v3/util/jsonutil" `

github-actions · 2025-01-30T12:28:23Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2db4f8f

madsense

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:28:	MakeRequests		89.5%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:61:	makeRequest		75.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:89:	getEndpointURL		100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:95:	MakeBids		94.4%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:14:	parseImpExt		75.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:34:	getHeaders		88.2%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:65:	getTypedBidFromBid	100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:88:	getMediaTypeForBid	100.0%
total:									(statements)		89.4%

madsenseops · 2025-02-19T09:11:17Z

@pm-jaydeep-mohite I addressed all comments, could you please review again?

bsardo · 2025-02-03T16:28:17Z

static/bidder-params/madsense.json

+    "company_id": {
+      "type": "string",
+      "description": "An id used to identify madSense company"
+    }


Just checking, how do you want to treat an empty string? If you require at least one character you should add a minLength property.

added minLength property

bsardo · 2025-02-03T16:30:02Z

adapters/madsense/params_test.go

+var validParams = []string{
+	`{"company_id": "9876543"}`,
+}
+
+var invalidParams = []string{
+	``,
+	`null`,
+	`true`,
+	`5`,
+	`4.2`,
+	`[]`,
+	`{}`,
+	`{"companyId": "987654a"}`,
+	`{"companyId": "98765432"}`,
+}


Please add a test for the company_id empty string case.

bsardo · 2025-02-03T16:30:48Z

static/bidder-info/madsense.yaml

@@ -0,0 +1,12 @@
+endpoint: "https://ads.madsense.io/pbs"
+maintainer:
+  email: "[email protected]"


Sent an email to this address. Please respond to the email with a "received" message.

bsardo · 2025-02-03T16:33:50Z

adapters/madsense/madsense_test.go

+
+func TestJsonSamples(t *testing.T) {
+	bidder, buildErr := Builder(openrtb_ext.BidderMadSense, config.Adapter{
+		Endpoint: "https://ads.madsense.io/pbs"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})


Nitpick: we recommend using test urls for maintenance reasons.

updated test urls

bsardo · 2025-02-03T16:40:08Z

adapters/madsense/madsense.go

+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) (requests []*adapters.RequestData, errors []error) {
+	reqs := make([]*adapters.RequestData, 0, len(request.Imp))
+	var errs []error


There's an issue here because you're mixing named returns with local variable declarations. I suggest deleting the named returns requests and errors and always using the local variables reqs and errs.

agreed, I switched to only using local variables

bsardo · 2025-02-25T15:55:25Z

adapters/madsense/utils.go

+		}
+
+		if len(request.Device.IPv6) > 0 {
+			headers.Add("X-Forwarded-For", request.Device.IPv6)


Please add test coverage for this line.

bsardo · 2025-02-25T15:55:32Z

adapters/madsense/utils.go

+			headers.Add("Origin", request.Site.Domain)
+		}
+		if request.Site.Ref != "" {
+			headers.Set("Referer", request.Site.Ref)


Please add test coverage for this line.

bsardo · 2025-02-25T15:56:45Z

adapters/madsense/madsense.go

+		return nil, []error{&errortypes.BadServerResponse{
+			Message: "Bad Server Response",
+		}}


Please add a supplemental test case where the response.Body unmarshal fails.

tested in new supplemental test bad-response-error

bsardo · 2025-02-25T15:57:22Z

adapters/madsense/madsense.go

+	}
+
+	if request.Test == 1 {
+		ext.CompanyId = "test"


Please add test coverage for this line.

tested in new supplemental test test-response

bsardo · 2025-02-25T15:59:59Z

adapters/madsense/madsensetest/supplemental/bad-request-example.json

Consider renaming this to bad-response-status-400.json.

github-actions · 2025-02-28T13:49:45Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c1696fb

madsense

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:28:	MakeRequests		89.5%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:61:	makeRequest		83.3%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:89:	getEndpointURL		100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/madsense.go:95:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:14:	parseImpExt		75.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:34:	getHeaders		100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:65:	getTypedBidFromBid	100.0%
github.com/prebid/prebid-server/v3/adapters/madsense/utils.go:88:	getMediaTypeForBid	100.0%
total:									(statements)		93.6%

scr-oath · 2025-02-26T03:12:50Z

adapters/madsense/madsense.go

+	}
+
+	request.Imp = imps
+	body, err := json.Marshal(request)


Please use jsonutil for marshaling

Submit madSense bidder adapter

c6dc0a9

madsenseops mentioned this pull request Jan 21, 2025

MadSense: pbs set to true prebid/prebid.github.io#5824

Open

7 tasks

bsardo added the adapter label Jan 22, 2025

bsardo self-assigned this Jan 22, 2025

pm-jaydeep-mohite reviewed Jan 30, 2025

View reviewed changes

madsenseops added 2 commits January 30, 2025 13:23

pr comments

33446bb

typo

2db4f8f

madsenseops requested a review from pm-jaydeep-mohite January 31, 2025 08:48

bsardo reviewed Feb 25, 2025

View reviewed changes

pr comments

c1696fb

scr-oath requested changes Feb 28, 2025

View reviewed changes

adapters/madsense/madsense.go

}

request.Imp = imps

body, err := json.Marshal(request)

Copy link

Contributor

scr-oath Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use jsonutil for marshaling

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: MadSense #4169

New Adapter: MadSense #4169

madsenseops commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

bsardo commented Jan 22, 2025

pm-jaydeep-mohite Jan 30, 2025

pm-jaydeep-mohite Jan 30, 2025

madsenseops Jan 30, 2025

pm-jaydeep-mohite Jan 30, 2025 •

edited

Loading

madsenseops Jan 30, 2025

pm-jaydeep-mohite Jan 30, 2025

madsenseops Jan 30, 2025

github-actions bot commented Jan 30, 2025

madsenseops commented Feb 19, 2025

bsardo Feb 3, 2025

madsenseops Feb 28, 2025

bsardo Feb 3, 2025 •

edited

Loading

madsenseops Feb 28, 2025

bsardo Feb 3, 2025

madsenseops Feb 28, 2025

bsardo Feb 3, 2025

madsenseops Feb 28, 2025

bsardo Feb 3, 2025

madsenseops Feb 28, 2025

bsardo Feb 25, 2025

madsenseops Feb 28, 2025

bsardo Feb 25, 2025

madsenseops Feb 28, 2025

bsardo Feb 25, 2025

madsenseops Feb 28, 2025

bsardo Feb 25, 2025

madsenseops Feb 28, 2025

bsardo Feb 25, 2025

madsenseops Feb 28, 2025

github-actions bot commented Feb 28, 2025

scr-oath Feb 26, 2025

New Adapter: MadSense #4169

Are you sure you want to change the base?

New Adapter: MadSense #4169

Conversation

madsenseops commented Jan 21, 2025

github-actions bot commented Jan 21, 2025

Code coverage summary

madsense

bsardo commented Jan 22, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pm-jaydeep-mohite Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2025

Code coverage summary

madsense

madsenseops commented Feb 19, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsardo Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 28, 2025

Code coverage summary

madsense

Choose a reason for hiding this comment

pm-jaydeep-mohite Jan 30, 2025 •

edited

Loading

bsardo Feb 3, 2025 •

edited

Loading