Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable deals for soft aliases #3391

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Pubmatic-Supriya-Patil
Copy link
Contributor

This PR solves issue mentioned in #3362

@bsardo bsardo self-assigned this Jan 9, 2024
@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil changed the base branch from master to analytics_activities_ufpd_geo January 11, 2024 06:02
@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil changed the base branch from analytics_activities_ufpd_geo to master January 11, 2024 06:03
@bsardo
Copy link
Collaborator

bsardo commented Jan 16, 2024

@Pubmatic-Supriya-Patil see my comment on the corresponding PR. I think we can still attempt to normalize the bidder name and if normalization fails, we can continue processing so that soft aliases are handled properly instead of skipping the bidder:

bidderNormalized, bidderFound := openrtb_ext.NormalizeBidderName(bidder.String())
if !bidderFound {
	... // handle soft aliases here
}

@bsardo bsardo changed the title Removed Normalize Bidder Name check from applyDealSupport Fix: Allow deals for soft aliases Jan 22, 2024
@bsardo bsardo changed the title Fix: Allow deals for soft aliases Fix: Enable deals for soft aliases Jan 22, 2024
@bsardo bsardo self-requested a review January 22, 2024 20:26
@bsardo bsardo merged commit 2ae62cf into prebid:master Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants