Adkernel: Add multiformat imp splitting #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebid-server into adkernel_multiformat
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| for _, imp := range imps { | ||
| if imp.ID == impID { | ||
| if imp.Banner != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
There was a problem hiding this comment.
@ckbo3hrk any thoughts on using MType field? This could simply getMediaTypeForImpID.
There was a problem hiding this comment.
@onkarvhanumante good idea, but at the moment integration endpoint does not return the bid.mtype field. I'll add support for this field to the endpoint later and simplify getMediaTypeForImpID with the next commit.
Code coverage summaryNote:
adkernelRefer here for heat map coverage report |
bsardo
changed the title
Code coverage summaryNote:
adkernelRefer here for heat map coverage report |
code review fix
Code coverage summaryNote:
adkernelRefer here for heat map coverage report |
gargcreation1992
approved these changes
Jan 19, 2024
onkarvhanumante
approved these changes
Jan 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split multiformat impression to single-format impressions with modified impid