Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bidder core name to BidderRequest hook #3389

Closed
wants to merge 1 commit into from

Conversation

linux019
Copy link
Contributor

@linux019 linux019 commented Jan 9, 2024

This example auction request to "/openrtb2/auction" contains bidders alias.

{ 
  "imp": [
        {
            "ext": {
                "prebid": {
                    "bidder": {
                        "rubicon_s2s": {
                            "accountId": 1234,
                            "siteId": 123,
                            "zoneId": 123
                        }
                    }
                }
            }
        }
    ],
 "ext": {
        "prebid": {
            "aliases": {
                "rubicon_s2s": "rubicon"
            }
        }
    }
}

I wrote a module for BidderRequestHook that needs a real bidder name but PBS passes to the hook a bidder alias but not the bidder core name
The resolving of aliases in the hook is inefficient since it is already done upstream in PBS core

@bsardo bsardo self-assigned this Jan 9, 2024
@bsardo bsardo removed their assignment Feb 7, 2024
@linux019 linux019 closed this Mar 4, 2024
@linux019 linux019 deleted the add-hook-bidder-core-name branch March 4, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants