Fix: increase tmax in flakey modularity test #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsardo
commented
Dec 19, 2023
| @@ -1579,7 +1579,7 @@ var entryPointHookUpdate = hooks.HookWrapper[hookstage.Entrypoint]{ | |||
|
|
|||
| ch := hookstage.ChangeSet[hookstage.EntrypointPayload]{} | |||
| ch.AddMutation(func(payload hookstage.EntrypointPayload) (hookstage.EntrypointPayload, error) { | |||
| body, err := jsonpatch.MergePatch(payload.Body, []byte(`{"tmax":50}`)) | |||
| body, err := jsonpatch.MergePatch(payload.Body, []byte(`{"tmax":600}`)) | |||
There was a problem hiding this comment.
This mutation had to be increased and instead of making it 500, I made it 600 so it still changes the tmax from what is in the request and is large enough to avoid deadline exceeded errors.
VeronikaSolovei9
approved these changes
Jan 2, 2024
AlexBVolcy
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tmax values for the test cases in
endpoints/openrtb2/auction_test.go#TestValidResponseAfterExecutingStagesappear to be too small such that they're causing occasional deadline exceeded errors when attempting to retrieve bids from the mock bidders.