Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove default-account from base floors container config #3735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Tests: Remove default-account from base floors container config #3735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsBaseSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ abstract class PriceFloorsBaseSpec extends BaseSpec {

public static final BigDecimal FLOOR_MIN = 0.5
public static final BigDecimal FLOOR_MAX = 2
public static final Map<String, String> FLOORS_CONFIG = ["price-floors.enabled" : "true",
"settings.default-account-config": encode(defaultAccountConfigSettings)]
public static final Map<String, String> FLOORS_CONFIG = ["price-floors.enabled": "true"]

protected static final String BASIC_FETCH_URL = networkServiceContainer.rootUri + FloorsProvider.FLOORS_ENDPOINT
protected static final int MAX_MODEL_WEIGHT = 100
Expand Down
4 changes: 2 additions & 2 deletions ...test/groovy/org/prebid/server/functional/tests/pricefloors/PriceFloorsFetchingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class PriceFloorsFetchingSpec extends PriceFloorsBaseSpec {

def "PBS should activate floors feature when price-floors.enabled = true in PBS config"() {
given: "Pbs with PF configuration"
def pbsService = pbsServiceFactory.getService(FLOORS_CONFIG + ["price-floors.enabled": "true"])
def pbsService = pbsServiceFactory.getService(FLOORS_CONFIG)

and: "Default BidRequest"
def bidRequest = BidRequest.getDefaultBidRequest(APP)
Expand All @@ -73,7 +73,7 @@ class PriceFloorsFetchingSpec extends PriceFloorsBaseSpec {

def "PBS should not activate floors feature when price-floors.enabled = false in #description config"() {
given: "Pbs with PF configuration"
def pbsService = pbsServiceFactory.getService(FLOORS_CONFIG + ["price-floors.enabled": pbdConfigEnabled])
def pbsService = pbsServiceFactory.getService(["price-floors.enabled": pbdConfigEnabled])

and: "Default BidRequest"
def bidRequest = BidRequest.getDefaultBidRequest(APP)
Expand Down
Loading