Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetVideo and Brid Adapter: Fixing schain #12821

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5752cae
TargetVideo bid adapter
grajzer Aug 24, 2021
0207a16
Merge branch 'prebid:master' into master
grajzer Aug 24, 2021
f1f0031
Merge branch 'prebid:master' into master
grajzer Aug 26, 2021
73ee74b
TargetVideo bid adapter
grajzer Aug 26, 2021
604352a
Merge branch 'prebid:master' into master
grajzer Sep 2, 2021
1abee7f
TargetVideo bid adapter
grajzer Sep 3, 2021
036a63a
Merge branch 'prebid:master' into master
grajzer Nov 16, 2021
b35ad19
Merge branch 'prebid:master' into master
grajzer Mar 11, 2022
3322d52
Merge branch 'prebid:master' into master
grajzer Mar 31, 2022
97a7550
Merge branch 'prebid:master' into master
grajzer Jun 21, 2022
6af3265
TargetVideo Bid Adapter: Add GDPR/USP support
grajzer Jun 21, 2022
c3c5250
Merge branch 'prebid:master' into master
grajzer Jul 5, 2022
3045532
TargetVideo Bid Adapter: Add GDPR/USP support tests
grajzer Jul 5, 2022
ddceb04
Merge branch 'prebid:master' into master
grajzer Nov 14, 2022
54eb92d
Merge branch 'prebid:master' into master
grajzer Jan 17, 2023
592af48
TargetVideo Bid Adapter: Updating margin rule
grajzer Jan 17, 2023
76f79f4
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Apr 12, 2023
79f3755
Merge branch 'prebid:master' into master
grajzer Apr 13, 2023
1d6265a
Add Brid bid adapter
grajzer Apr 13, 2023
64c63de
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Jun 22, 2023
ac60eed
Brid adapter requested changes
grajzer Jun 22, 2023
d9875e9
Merge branch 'prebid:master' into master
grajzer Sep 20, 2023
32497f5
Merge branch 'prebid:master' into master
grajzer May 16, 2024
2f17f98
BridBidAdapter: switching to plcmt
grajzer May 16, 2024
7366a56
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Sep 2, 2024
d55be7c
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Sep 17, 2024
f3cd067
Brid Bid Adapter: getUserSyncs method and interpretResponse updates
grajzer Sep 17, 2024
3b1dc82
Adding missing semicolon
grajzer Oct 24, 2024
ff666ad
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Nov 18, 2024
0190a7b
TargetVideo Bid Adapter : user sync and response changes
grajzer Nov 18, 2024
38a408f
TargetVideo Bid Adapter : removing duplicate code
grajzer Nov 18, 2024
822377c
Merge branch 'master' of https://github.com/grajzer/Prebid.js
grajzer Feb 28, 2025
ac08fdc
TargetVideo and Brid video adapters: fixing schain
grajzer Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/bridBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ export const spec = {
};

if (bidRequests[0].schain) {
postBody.schain = bidRequests[0].schain;
postBody.source = {
ext: { schain: bidRequests[0].schain }
};
}

const params = bid.params;
Expand Down
4 changes: 3 additions & 1 deletion modules/targetVideoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export const spec = {
};

if (bidRequests[0].schain) {
payload.schain = bidRequests[0].schain;
payload.source = {
ext: { schain: bidRequests[0].schain }
};
}

requests.push(formatRequest({ payload, url: VIDEO_ENDPOINT_URL, bidId }));
Expand Down
24 changes: 24 additions & 0 deletions test/spec/modules/bridBidAdapter_spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { spec } from '../../../modules/bridBidAdapter.js'
import { SYNC_URL } from '../../../libraries/targetVideoUtils/constants.js';
import { deepClone } from '../../../src/utils.js';

describe('Brid Bid Adapter', function() {
const videoRequest = [{
Expand Down Expand Up @@ -37,6 +38,29 @@ describe('Brid Bid Adapter', function() {
expect(payload.imp[0].ext.prebid.storedrequest.id).to.equal(12345);
});

it('Test the request schain sending', function() {
const globalSchain = {
ver: '1.0',
complete: 1,
nodes: [{
asi: 'examplewebsite.com',
sid: '00001',
hp: 1
}]
};

let videoRequestCloned = deepClone(videoRequest);
videoRequestCloned[0].schain = globalSchain;

const request = spec.buildRequests(videoRequestCloned, videoRequestCloned[0]);
expect(request).to.not.be.empty;

const payload = JSON.parse(request[0].data);
expect(payload).to.not.be.empty;
expect(payload.source.ext.schain).to.exist;
expect(payload.source.ext.schain).to.deep.equal(globalSchain);
});

it('Test nobid responses', function () {
const responseBody = {
'id': 'test-id',
Expand Down
34 changes: 31 additions & 3 deletions test/spec/modules/targetVideoBidAdapter_spec.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
import { spec } from '../../../modules/targetVideoBidAdapter.js'
import { SYNC_URL } from '../../../libraries/targetVideoUtils/constants.js';
import { deepClone } from '../../../src/utils.js';

describe('TargetVideo Bid Adapter', function() {
const bidder = 'targetVideo';
const params = {
placementId: 12345,
};

const defaultBidderRequest = {
bidderRequestId: 'mock-uuid',
};

const bannerRequest = [{
bidder,
params,
Expand Down Expand Up @@ -38,7 +43,7 @@ describe('TargetVideo Bid Adapter', function() {
});

it('Test the BANNER request processing function', function() {
const request = spec.buildRequests(bannerRequest, bannerRequest[0]);
const request = spec.buildRequests(bannerRequest, defaultBidderRequest);
expect(request).to.not.be.empty;

const payload = JSON.parse(request.data);
Expand All @@ -53,7 +58,7 @@ describe('TargetVideo Bid Adapter', function() {
});

it('Test the VIDEO request processing function', function() {
const request = spec.buildRequests(videoRequest, videoRequest[0]);
const request = spec.buildRequests(videoRequest, defaultBidderRequest);
expect(request).to.not.be.empty;

const payload = JSON.parse(request[0].data);
Expand All @@ -65,6 +70,29 @@ describe('TargetVideo Bid Adapter', function() {
expect(payload.imp[0].ext.prebid.storedrequest.id).to.equal(12345);
})

it('Test the VIDEO request schain sending', function() {
const globalSchain = {
ver: '1.0',
complete: 1,
nodes: [{
asi: 'examplewebsite.com',
sid: '00001',
hp: 1
}]
};

let videoRequestCloned = deepClone(videoRequest);
videoRequestCloned[0].schain = globalSchain;

const request = spec.buildRequests(videoRequestCloned, defaultBidderRequest);
expect(request).to.not.be.empty;

const payload = JSON.parse(request[0].data);
expect(payload).to.not.be.empty;
expect(payload.source.ext.schain).to.exist;
expect(payload.source.ext.schain).to.deep.equal(globalSchain);
});

it('Handle BANNER nobid responses', function() {
const responseBody = {
'version': '0.0.1',
Expand Down Expand Up @@ -170,7 +198,7 @@ describe('TargetVideo Bid Adapter', function() {
expect(bid.width).to.equal(640);
expect(bid.height).to.equal(480);
expect(bid.currency).to.equal('USD');
})
});

it('Test BANNER GDPR consent information is present in the request', function() {
let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A==';
Expand Down