Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPOM Bid Adapter : initial release #12687

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

epomrnd
Copy link

@epomrnd epomrnd commented Jan 23, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):

  • modules/epomDspBidAdapter.js (+1 warning)

@ChrisHuie ChrisHuie changed the title Add EPOM Bid Adapter EPOM Bid Adapter : initial release Jan 24, 2025
@ChrisHuie ChrisHuie requested a review from ncolletti January 30, 2025 12:36
const requests = bidRequests.map((bid) => {
const endpoint = bid.params?.endpoint || globalSettings.endpoint;
const payload = {
...bid,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, without filtering this can be a lot of data for some publisher auction configurations

Comment on lines 40 to 50
bids: [
{
bidder: 'epomDsp', // Adapter code
params: {
endpoint: 'https://your-epom-endpoint.com/bid', // Epom DSP endpoint
},
adUnitId: 'sampleAdUnitId123', // Unique Ad Unit ID
bidfloor: 0.5, // Minimum bid floor (optional)
}
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your example bid params need to be real, we expect to see bids returned from your adapter so that we can confirm your integration works in our testing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added real data and real endpoint. You may use this to confirm integration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epomrnd Sorry for the delay. I checked your provided params in the GPT hello world example and am seeing 204s returned, can you set your endpoint to return creatives on requests from these params? This is the last change needed on your PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncolletti I added data for testing in prebid.github.io PR. Actual adUnits data:

var adUnits = [ { code: 'epom-banner-div', mediaTypes: { banner: { sizes: [ [300, 250] ] } }, bids: [ { bidder: 'epom_dsp', params: { endpoint: 'https://bidder.epommarket.com/bidder/v2_5/bid?key=d0b9fb9de9dfbba694dfe75294d8e45a' }, "imp": [ { "banner": { "w": 300, "h": 250, "btype": [ 4 ], "pos": 0, "api": [ 3 ] }, "instl": 0, "tagid": "test4", "bidfloor": 0.01, "bidfloorcur": "USD", "id": "2" } ], "site": { "id": "fc59bd54-36df-4d33-830c-fdsfds", "domain": "epom.com", "privacypolicy": 0, "publisher": { "id": "testid" }, "content": { "id": "1234567", "episode": 23, "title": "Car Show", "series": "All About Cars", "season": "2", "cat": [ "IAB2-2" ] } }, "device": { "ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36", "geo": { "country": "UKR", "region": "", "city": "" }, "ip": "176.112.120.50", "devicetype": 2, "os": "windows", "osv": "", "js": 1, "language": "US", "carrier": "VERIZON", "connectiontype": 5, "ifa": "AA000DFE74168477C70D291f574D344790E0BB11" }, "user": { "id": "testiduser" }, "test": 0, "at": 2, "allimps": 0, "cur": [ "USD" ], "bcat": [ "IAB25-2", "IAB25-1" ], "badv": [], "id": "NewIdTest" } ] } ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants