Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Improve layout and readability of contact details page. #1311

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hodgestar
Copy link
Contributor

Currently the contact details page seems really oddly and un-compactly laid out to me. Currently it looks like:
screenshot from 2015-07-09 09 20 45
...
screenshot from 2015-07-09 09 21 25
Perhaps we need to allow the non-editable information (extras and subcriptions) to re-flow to a second column?

@hodgestar
Copy link
Contributor Author

@justinvdm @SteveBarnett Thoughts when you're back?

@SteveBarnett
Copy link
Contributor

@hodgestar Agreed. I'll have a quick look today.

@hodgestar
Copy link
Contributor Author

hodgestar commented Jul 13, 2015 via email

@SteveBarnett
Copy link
Contributor

We should:

  • remove col-md-4 from the div;
  • add a col-md-4 class to section.profile;
  • add a col-md-4 class and col-md-push-1 class to section.extras;
  • move the Save changes button to outside the div (so that it doesn't wrap funny).

@hodgestar writing this ^^^ rather than doing this because I should be doing numi stuff and I don't want to get told off by @badlard. Also worried about running into my usual getting-my-local-vumi-go-running rabbit hole. :D

@hodgestar
Copy link
Contributor Author

Not ready for review, but I started by cleaning up the structure to look more like idiomatic bootstrap and less special sauce.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants