Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Add dialogue action for sending over a different channel #1042

Conversation

justinvdm
Copy link
Contributor

We need a way to choose to send a single message over a different channel (for example, SMS) than the main channel the dialogue conversation is being run over (for example, USSD).

@justinvdm
Copy link
Contributor Author

@SteveBarnett Ready for review.

The content in the template probably needs changing, would like your input there.

Also still need to put a 'You need to hook up this channel on the routing screen' message somewhere. Only showing the message when it hasn't been hooked up is a bit more complicated, so we either need to come up with a message that makes sense either way, or add a context-dependant message in a separate PR.

@hodgestar
Copy link
Contributor

Looks good to me. I think the Travis build failure is spurious (it only happened on Python 2.6 and it was a timeout during the PhantomJS tests) so I restarted the build.

@justinvdm
Copy link
Contributor Author

@hodgestar thanks for review :) I'm going to wait for @SteveBarnett to take a look at the content, html and css parts, because I'm pretty sure some improvement will be needed there.

@SteveBarnett
Copy link
Contributor

@justinvdm: content in the template looks good to me. It's consistent voice and tone with the other bits. I think #1046 will do the most to make this bit less confusing. I will add the need to hook up msg.

@SteveBarnett
Copy link
Contributor

@justinvdm I was thinking about adding "You can set this in Configure channels," but was worried about people clicking that and either losing work (from not saving) or getting lost (if we had used target="_blank" on the link).

@justinvdm
Copy link
Contributor Author

@SteveBarnett thanks for the change :) ya, also thought about that, I think its okay as is though.

@justinvdm justinvdm merged commit 6aada15 into develop Nov 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants