Add some tests for ordered sets to verify that they are unique by slug & locale #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Nov 26, 2024
| ) -> None: | ||
| """ | ||
| Importing CSV for ordered content sets with a duplicate name but unique slugs | ||
| should not throw an error. |
There was a problem hiding this comment.
I think here we have duplicate names and slugs, and it seems like the action is to only choose one of them?
There was a problem hiding this comment.
Yes, I would expect the last one in the file to take effect because we don't do a full file scan up front to see if there are duplicates in the file.
If we only had non-unique names and 2 sets with the same name then it's anyone's guess which one would be updated.
I'll update the comment.
rudigiesler
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ordered sets were unique by name, now they are unique by slug and locale. We want to verify that that is true.
Solution
I added some more tests
Checklist