added homepaage locale setting #261
Conversation
contentrepo/settings/base.py
Outdated
| @@ -32,7 +32,8 @@ | |||
| "wagtail_content_import.pickers.local", | |||
| "wagtail.admin", | |||
| "wagtail", | |||
| "wagtail.locales", | |||
| "wagtail_localize", | |||
| "wagtail_localize.locales", | |||
There was a problem hiding this comment.
According to https://wagtail-localize.org/latest/tutorial/2-configure-wagtail-localize/ , this should be placed between search and wagtail.contrib.forms.
It also says that wagtail_localize.locales is temporary and will be removed in future, so maybe we should stick with wagtail.locales?
requirements.txt
Outdated
| @@ -3,6 +3,7 @@ wagtail==5.0.5 | |||
| wagtailmedia | |||
| psycopg2-binary | |||
| wagtail-content-import | |||
| wagtail-localize | |||
There was a problem hiding this comment.
Taking a brief look at the docs, this gives us integrations with external translation services, and the ability to work with PO files, which are not things that we've really needed for contentrepo. What does this give us that we want to include it?
There was a problem hiding this comment.
This allows the user to create a HomePage with a non default locale as far as I understand. Without it, the admin UI will still allow you to create locales, but the Homepage with that locale will not be created(which is something we want).
There was a problem hiding this comment.
On my local instance (without these changes), if I go settings -> Locales, and then add a locale. I can then either go to the english homepage, click the kebab menu and select translate, which will copy that whole tree into the new locale, creating the new homepage with all the required pages.
There was a problem hiding this comment.
I didn't know that. That works for me too. I will remove it then.
|
Test added :) |
README.md
Outdated
| @@ -105,6 +105,9 @@ Authentication is required to access the API. Session, basic, and token authenti | |||
|
|
|||
| To create an authentication token, you can do so via the Django Admin (available at the `/django-admin` endpoint), or by `POST`ing the username and password of the user you want to generate a token for to the `/api/v2/token/` endpoint. | |||
|
|
|||
| ### Internationalisation | |||
| To create or import pages in other languages, the user must first create the locale in the specified language. To create a new locale, go to "Settings" => "Locales" in the admin interface, and click "Add a new locale". Set the "Sync from" field to "English". This keeps the the specified language tree in sync with any existing and new English content as it's authored. After you press "Save", there should be two "Home" pages in the page explorer. | |||
There was a problem hiding this comment.
Was this "Sync from" instruction from that additional library? I think we need to update this to where you select "Add translation" to the base language homepage.
There was a problem hiding this comment.
Good observation. I fixed this.
Purpose
The importer was not picking up cases where the a a childpage was attempting to be linked to a homepage of a different locale. This caused the import to fail, without a descriptive reason to the user.
Approach
If a childpage attempts to link to a homepage that does not exist during import, the UI will return an error that will allow the user to fix it.