Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when exporting data with media or images. #251

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

HawkiesZA
Copy link
Contributor

Purpose

To allow exporting to xlsx when pages have media. (Link to ticket.)[https://praekelt.leankit.com/card/31512190149211]

Approach

Instead of exporting the entire image / media, this exports the URL

rudigiesler
rudigiesler previously approved these changes Feb 13, 2024
Copy link
Contributor

@rudigiesler rudigiesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HawkiesZA HawkiesZA merged commit 9ddd6ae into main Feb 19, 2024
4 checks passed
@HawkiesZA HawkiesZA deleted the 1085-fix-exporting-with-media branch February 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants