Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed import name and fixed typo in test #249

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Conversation

Mudiwa66
Copy link
Contributor

@Mudiwa66 Mudiwa66 commented Feb 8, 2024

Purpose

The import button on the edit page is to import a word document into the web section of the page, so we want to change to text to "Import web from doc"

Approach

The import button is more descriptive

@Mudiwa66 Mudiwa66 requested a review from jerith February 8, 2024 09:41
@Mudiwa66
Copy link
Contributor Author

@jerith any idea why this would fail? It works on my machine, looks like some missing css content. All my migrations are up to date as well.

@jerith
Copy link
Member

jerith commented Feb 14, 2024

As discussed on slack: We're apparently using a staticfiles storage backend that isn't test-friendly. The quickest fix is probably to change the storage backend in the dev or test settings file.

@Mudiwa66
Copy link
Contributor Author

Seems to be working now.

Copy link
Member

@jerith jerith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Mudiwa66 Mudiwa66 merged commit c8bb1d3 into main Feb 14, 2024
4 checks passed
@Mudiwa66 Mudiwa66 deleted the import-name-update branch February 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants