Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More import error juggling #241

Merged
merged 3 commits into from
Jan 30, 2024
Merged

More import error juggling #241

merged 3 commits into from
Jan 30, 2024

Conversation

jerith
Copy link
Member

@jerith jerith commented Jan 29, 2024 •
edited
Loading

Purpose

Turn more things into ImportException.

Specifically, this catches validation errors during page update.

@jerith jerith marked this pull request as ready for review January 29, 2024 15:09
@jerith
Copy link
Member Author

jerith commented Jan 29, 2024

I didn't wrap the save_revision() calls in the related page and button handlers, because I wasn't able to come up with a scenario that failed in those places.

@jerith jerith merged commit 752f387 into main Jan 30, 2024
4 checks passed
@jerith jerith deleted the more-import-error-juggling branch January 30, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudigiesler rudigiesler rudigiesler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerith @rudigiesler