Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed web preview #239

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fixed web preview #239

merged 3 commits into from
Jan 30, 2024

Conversation

Mudiwa66
Copy link
Contributor

Purpose

On our CMS, users are not able to preview their changes. A basic template needs to be created, that will display those changes in real time.

Approach

The user is now able to preview their changes in real time. The user can also open a new tab that will display the content on an entire webpage.

@Mudiwa66 Mudiwa66 requested a review from rudigiesler January 29, 2024 07:29
Copy link
Contributor

@rudigiesler rudigiesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the fields that have been chosen to display

<h1>{{ page.title }}</h1>
<p class="meta">{{ page.date }}</p>

<div class="intro">{{ page.intro }}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have date and intro fields in our ContentPage model. We do have title, subtitle, and body though (at least for the web section of the page)

@Mudiwa66 Mudiwa66 merged commit 0e6aa4d into main Jan 30, 2024
4 checks passed
@Mudiwa66 Mudiwa66 deleted the preview-fix branch January 30, 2024 08:58
@MatthewWeppenaar MatthewWeppenaar restored the preview-fix branch August 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants