Mnch 985 contentrepo whatsapp template #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jerith for review please |
jerith
reviewed
Jan 4, 2024
home/models.py
Outdated
| @@ -605,6 +605,8 @@ def latest_revision_rating(self): | |||
|
|
|||
| @property | |||
| def whatsapp_template_prefix(self): | |||
| if self.whatsapp_title: | |||
| self.whatsapp_title = self.whatsapp_title.lower() | |||
There was a problem hiding this comment.
Do we want to set self.whatsapp_title to lowercase here, or just return a lowercase version of it?
Also, on the line below we call .replace() on it unconditionally. That means we don't need to check if it's non-empty before lowercasing it.
rudigiesler
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Looks good!
I think we might want a data migration, to lowercase all the existing template names that are in the database, see https://github.com/praekeltfoundation/contentrepo/blob/main/home/migrations/0030_contentpage_whatsapp_template_name.py for an example, but happy for that to happen in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem or feature in addition to a link to the issues.
Template was store with uppercase and throw an error when they try to retrieve it as template names are stored with lower case.
Approach
How does this change address the problem?
Convert whatsapp template name to lower case before we store it.
Open Questions and Pre-Merge TODOs
Learning
Describe the research stage
Create a whatsapp template locally and modify unittests
Links to blog posts, patterns, libraries or addons used to solve this problem
None
Blog Posts