Skip to content

Commit

Permalink
fix: fix when empty price from coingecko
Browse files Browse the repository at this point in the history
  • Loading branch information
pradel committed Oct 22, 2024
1 parent a1d4909 commit 25ac83b
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 12 deletions.
5 changes: 5 additions & 0 deletions .changeset/silver-ligers-repair.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"stackspulse": patch
---

Fix tokens page when empty price returned from Coingecko.
6 changes: 3 additions & 3 deletions apps/server/src/api/tokens/markets.get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ type CoingeckoCoinsMarketsResponse = {
symbol: string;
name: string;
image: string;
current_price: number;
market_cap: number;
price_change_percentage_24h: number;
current_price?: number;
market_cap?: number;
price_change_percentage_24h?: number;
}[];

type TokensMarketsRouteResponse = CoingeckoCoinsMarketsResponse;
Expand Down
18 changes: 12 additions & 6 deletions apps/web/src/app/tokens/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,20 @@ export default async function ProtocolPage() {
)}
</Table.Cell>
<Table.Cell align="right">
$
{market.current_price.toLocaleString("en-US", {
maximumFractionDigits: 12,
})}
{market.current_price
? `$${market.current_price.toLocaleString("en-US", {
maximumFractionDigits: 12,
})}`
: ""}
</Table.Cell>
<Table.Cell align="right">
<Text
size="2"
color={
market.price_change_percentage_24h >= 0 ? "green" : "red"
market.price_change_percentage_24h &&
market.price_change_percentage_24h >= 0
? "green"
: "red"
}
>
{market.price_change_percentage_24h
Expand All @@ -81,7 +85,9 @@ export default async function ProtocolPage() {
</Text>
</Table.Cell>
<Table.Cell align="right">
${market.market_cap.toLocaleString("en-US")}
{market.market_cap
? `$${market.market_cap.toLocaleString("en-US")}`
: ""}
</Table.Cell>
</Table.Row>
))}
Expand Down
6 changes: 3 additions & 3 deletions apps/web/src/lib/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ type CoingeckoCoinsMarketsResponse = {
symbol: string;
name: string;
image: string;
current_price: number;
market_cap: number;
price_change_percentage_24h: number;
current_price?: number;
market_cap?: number;
price_change_percentage_24h?: number;
}[];

export type TokensMarketsRouteResponse = CoingeckoCoinsMarketsResponse;
Expand Down

0 comments on commit 25ac83b

Please sign in to comment.