-
Notifications
You must be signed in to change notification settings - Fork 23
Windows suppport #61
base: master
Are you sure you want to change the base?
Windows suppport #61
Conversation
… windows-suppport
@@ -38,7 +38,7 @@ class Phantomjs extends EventEmitter | |||
if useSystemPhantomjs | |||
process.env.PATH = DEFAULT_PATH | |||
else | |||
process.env.PATH = path.dirname(phantomjs.path) + ':' + DEFAULT_PATH | |||
process.env.PATH = path.dirname(phantomjs.path) + path.delimiter + DEFAULT_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Still some issue on windows 10 Native thread-sleep not available.
It can be fixed it by adding Meteor pid and MongoDB pid are not correctly retrieved - cross-spawn
|
@serut thanks for insigth I didn't saw that problem, working on it. |
…ackage dependency.
@jsep I've implemented the fix to retrieve the good meteor pid : https://github.com/serut/spacejam/commit/c3c60c2cdea47fae07ecde2e63846320ff28f5ea Tested on windows 10 (no zombie process), OS X and travis. |
…n 0.10) and remove Cake compilation of lib/*.coffee otherwise it creates a mess with windows pid
I have again that warning on my log :
So I added Also, on windows, I have a strange behaviour when coffeescript files are compiled. There are two processes to dig to get the mongo pid, but if I compile (with cake) lib/*.coffee into js files there are 4 processes to dig to get the mongo pid (I commited that yesterday). So I remove that compilation and I update the algorithm to dig only on 2 processes. (is it understandable ? ;-) ). I hope this time it will be stable. It looks good on travis, circleci and windows, but some feedback would be helpful ! Here is the diff : windows-suppport...serut:windows-suppport-pr |
Hello @serut thanks, I was testing your code and I notice that too. Now I'm going to test your new changes. Thanks a lot! |
it's definitely a perfect release for me, it does its job so far. Tested on Windows, Travis, Circle, OSX, Meteor 1.4.0.X |
@jsep @rbabayoff any improvement with this PR ? Do you need some help with these spacejam tests ? |
No description provided.