Skip to content
This repository has been archived by the owner on Dec 27, 2018. It is now read-only.

Windows suppport #61

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Windows suppport #61

wants to merge 26 commits into from

Conversation

jsep
Copy link

@jsep jsep commented Jun 29, 2016

No description provided.

@@ -38,7 +38,7 @@ class Phantomjs extends EventEmitter
if useSystemPhantomjs
process.env.PATH = DEFAULT_PATH
else
process.env.PATH = path.dirname(phantomjs.path) + ':' + DEFAULT_PATH
process.env.PATH = path.dirname(phantomjs.path) + path.delimiter + DEFAULT_PATH
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@serut
Copy link

serut commented Jun 30, 2016

Still some issue on windows 10

Native thread-sleep not available.

D:\dev\meteor-app>spacejam test-packages
Native thread-sleep not available.
This will result in much slower performance, but it will still work.
You should re-install spawn-sync or upgrade to the lastest version of node if possible.

It can be fixed it by adding "try-thread-sleep": "1.0.0", to the package.json of spacejam
(source: google/web-starter-kit#691).
I also updated cross-spawn to ^4.0.0 and spacejam is still launching meteor !

Meteor pid and MongoDB pid are not correctly retrieved - cross-spawn

issue with pid mongodb
On windows and when you use cross-spawn, it is cmd.exe that launch node. So when you retrieve the meteor pid you get the cmd.exe pid and you get the node pid instead of the mongodb pid. What a mess... Did you saw such issue before ?
When I run spacejam on windows I need to kill zombie processes to rerun spacejam again.

@jsep
Copy link
Author

jsep commented Jun 30, 2016

@serut thanks for insigth I didn't saw that problem, working on it.

@serut
Copy link

serut commented Jul 7, 2016

@jsep I've implemented the fix to retrieve the good meteor pid : https://github.com/serut/spacejam/commit/c3c60c2cdea47fae07ecde2e63846320ff28f5ea
I also found out that if I put coffee-script as a dependency of spacejam we do not have to execute npm install -g [email protected] anymore ! ;-)
And I do not have the Native thread-sleep not available. issue, don't know why.

Tested on windows 10 (no zombie process), OS X and travis.

@serut
Copy link

serut commented Jul 8, 2016

I have again that warning on my log :

Native thread-sleep not available.
This will result in much slower performance, but it will still work.
You should re-install spawn-sync or upgrade to the lastest version of node if possible.

So I added "try-thread-sleep": "1.0.0" (otherwise need to update node to any version > 0.10) (repro here on the first test : codecov)

Also, on windows, I have a strange behaviour when coffeescript files are compiled. There are two processes to dig to get the mongo pid, but if I compile (with cake) lib/*.coffee into js files there are 4 processes to dig to get the mongo pid (I commited that yesterday). So I remove that compilation and I update the algorithm to dig only on 2 processes. (is it understandable ? ;-) ). I hope this time it will be stable. It looks good on travis, circleci and windows, but some feedback would be helpful !

Here is the diff : windows-suppport...serut:windows-suppport-pr

@jsep
Copy link
Author

jsep commented Jul 8, 2016

Hello @serut thanks, I was testing your code and I notice that too. Now I'm going to test your new changes.

Thanks a lot!

@serut
Copy link

serut commented Aug 9, 2016

it's definitely a perfect release for me, it does its job so far. Tested on Windows, Travis, Circle, OSX, Meteor 1.4.0.X

@serut
Copy link

serut commented Aug 27, 2016

@jsep @rbabayoff any improvement with this PR ? Do you need some help with these spacejam tests ?
My pull request with coverage is also quite good if you want to look at

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants