Complete files from pwd #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Often, it is useful to not only complete relative filepaths as relative to the currently edited file, but also to complete files relative to the current cwd (one example being scripts like sudoedit which copy the script into a temporary file under /tmp by default and perform their edits there).
|
Can you rebase with latest master. Also would be good to have a flag for this which can be turned on or off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, it is useful to not only complete relative filepaths as relative
to the currently edited file, but also to complete files relative to
the current processes cwd (one example being scripts like sudoedit which copy the
script into a temporary file under /tmp by default and perform their
edits there but do not modify the cwd). This commit enables completion of files relative to the processes cwd.
This pull request currently is more a proposal, as it currently enables completion from pwd unconditionally.
However, this might not be desired in all cases. Yet, traditional approaches (such as matching on filetypes, having a bufferlocal enable/disable etc) all seem cumbersome to use for the end user. Furthermore, I personally do not see too much harm in enabling this completion variant globally (after all, the plugin runs async and the only visible result is a small number of additional completion candidates).