Skip to content

Fix song select right click handling #23948

Fix song select right click handling

Fix song select right click handling #23948

GitHub Actions / Results failed Jan 21, 2025 in 0s

43411 passed, 1 failed and 320 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 10853✅ 80⚪ 2512s
TestResults-Linux-SingleThread.trx 10852✅ 1❌ 80⚪ 2029s
TestResults-Windows-MultiThreaded.trx 10853✅ 80⚪ 2949s
TestResults-Windows-SingleThread.trx 10853✅ 80⚪ 2597s

✅ TestResults-Linux-MultiThreaded.trx

10933 tests were completed in 2512s with 10853 passed, 0 failed and 80 skipped.

❌ TestResults-Linux-SingleThread.trx

10933 tests were completed in 2029s with 10852 passed, 1 failed and 80 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation 39✅ 1❌ 8s

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation

✅ TestAddAudioTrack
✅ TestAddAudioTrack
✅ TestBackgroundFileChangesPreserveOnEncode
✅ TestBackgroundFileChangesPreserveOnEncode
✅ TestConstructor
✅ TestConstructor
✅ TestCopyDifficulty
✅ TestCopyDifficulty
✅ TestCopyDifficultyDoesNotChangeCollections
✅ TestCopyDifficultyDoesNotChangeCollections
✅ TestCreateMultipleNewDifficultiesSucceeds
✅ TestCreateMultipleNewDifficultiesSucceeds
✅ TestCreateNewBeatmap
✅ TestCreateNewBeatmap
✅ TestCreateNewDifficulty(False)
✅ TestCreateNewDifficulty(False)
✅ TestCreateNewDifficulty(True)
✅ TestCreateNewDifficulty(True)
✅ TestCreateNewDifficultyForInconvertibleRuleset
✅ TestCreateNewDifficultyForInconvertibleRuleset
✅ TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset
❌ TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset
	System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
✅ TestCreateNewDifficultyWithScrollSpeed_SameRuleset
✅ TestCreateNewDifficultyWithScrollSpeed_SameRuleset
✅ TestExitBlockedWhenSavingBeatmapWithSameNamedDifficulties
✅ TestExitBlockedWhenSavingBeatmapWithSameNamedDifficulties
✅ TestExitWithoutSave
✅ TestExitWithoutSave
✅ TestMultipleAudioFiles
✅ TestMultipleAudioFiles
✅ TestMultipleBackgroundFiles
✅ TestMultipleBackgroundFiles
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(False)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(False)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(True)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(True)
✅ TestSingleAudioFile
✅ TestSingleAudioFile
✅ TestSingleBackgroundFile
✅ TestSingleBackgroundFile

✅ TestResults-Windows-MultiThreaded.trx

10933 tests were completed in 2949s with 10853 passed, 0 failed and 80 skipped.

✅ TestResults-Windows-SingleThread.trx

10933 tests were completed in 2597s with 10853 passed, 0 failed and 80 skipped.

Annotations

Check failure on line 144 in osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation ► TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
Raw output
System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
   at osu.Framework.Bindables.BindableList`1.insert(Int32 index, T item, HashSet`1 appliedInstances)
   at osu.Framework.Bindables.BindableList`1.insert(Int32 index, T item, HashSet`1 appliedInstances)
   at osu.Game.Beatmaps.ControlPoints.ControlPointInfo.GroupAt(Double time, Boolean addIfNotExisting) in /home/runner/work/osu/osu/osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs:line 144
   at osu.Game.Beatmaps.ControlPoints.ControlPointInfo.Add(Double time, ControlPoint controlPoint) in /home/runner/work/osu/osu/osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs:line 125
   at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<>c__DisplayClass20_0.<TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset>b__4() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Editing/TestSceneEditorBeatmapCreation.cs:line 276
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)