Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display up to 2 decimal places for bpm in timing screen metronome #31586

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

minetoblend
Copy link
Contributor

Addresses part of #31263

Displays the bpm value in the metronome with up to 2 decimal places.
While interpolating, the value will be displayed as an integer, since going between 2 integer bpm values looks kinda jank otherwise. Once the value is within 1 bpm of the target value it will display the final value with up to 2 decimal places.

Screen.Recording.2025-01-20.at.00.50.08.mov

For comparison, here's the jankiness that would result from not applying the rounding.

Screen.Recording.2025-01-20.at.01.08.28.mov

@peppy
Copy link
Member

peppy commented Jan 20, 2025

Dunno. Metronomes usually are not accurate to decimal points. I'd personally say that the physical metronome should round to int still.

But if this is seen as a breaking usability concern then 🤷

@minetoblend
Copy link
Contributor Author

minetoblend commented Jan 20, 2025

If the metronome was less prominent I'd probably agree. However, given that

  • The actual text box for the bpm is off-screen by default
  • It moves & makes sounds so it draws extra attention

makes the metronome extremely prominent on the timing screen and displaying everything rounded to the nearest integer just conveys incorrect information.
image

image Since the timing point rows only display one decimal place, does showing just one decimal sound like a compromise here? While having timing points that require 2 decimal places is not very common, having values that end in 0.5 is common enough to warrant the extra precision imo.

@peppy peppy self-requested a review January 21, 2025 05:38
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 21, 2025
@peppy
Copy link
Member

peppy commented Jan 21, 2025

Made some changes.

Of note, this now displays more precision than other places in the editor. Which is weird, but needs to be addressed elsewhere if at all.

@peppy peppy merged commit 0a97fb6 into ppy:master Jan 21, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants