Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Conditional SkillRating nerf to Converts #31196

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Lawtrohux
Copy link
Member

@Lawtrohux Lawtrohux commented Dec 19, 2024

With the addition of monostaminafactor, the blanket convert nerf for values above 8* doesn't make sense, this uncaps the blanket nerf to starRating where colourRating < 2 and staminaRating > 8.

This provides no value changes to most maps, as there is only one significant converts that meets this requirement. The only noticeable change will be (among the lower dt scores) will be:

Ney: 28065 - StrangeProgram by DJ Sharpnel (HDDTFL) 96.34, 2x | Old = 659.21pp | New = 1009.77pp

New including #31195 - 1137.18pp

Old:
SR NM - 7.95* : SR DT - 8.32*

New:
SR NM - 7.95* : SR DT - 10.40*

@Lawtrohux Lawtrohux requested a review from a team December 19, 2024 12:39
Copy link

@YaniFR YaniFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tsunyoku tsunyoku requested review from tsunyoku and a team and removed request for tsunyoku December 19, 2024 16:34
@tsunyoku tsunyoku enabled auto-merge (squash) December 19, 2024 16:41
@tsunyoku tsunyoku merged commit d8c3d89 into ppy:pp-dev Dec 19, 2024
8 checks passed
@Lawtrohux Lawtrohux deleted the convert-revert branch December 19, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

3 participants