-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slider MinimumJumpDistance
being calculated too low to be possible
#30036
base: pp-dev
Are you sure you want to change the base?
Conversation
This whole In the current system:
The whole This change fixes the second part, and makes |
…than start-to-start jump
@@ -197,7 +197,7 @@ private void setDistances(double clockRate) | |||
|
|||
float distanceBetweenStartPositions = (BaseObject.StackedPosition * scalingFactor - lastObject.StackedPosition * scalingFactor).Length; | |||
|
|||
if (MinimumJumpDistance < distanceBetweenStartPositions) | |||
if (MinimumJumpDistance < distanceBetweenStartPositions && LazyJumpDistance >= distanceBetweenStartPositions) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nd distanceBetweenStartPositions for close-to-zero cases
!diffcalc |
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/12272699486 |
!diffcalc |
!diffcalc |
This comment was marked as outdated.
This comment was marked as outdated.
915223c
to
7765c2f
Compare
Replaces #29994 since this is a proper fix of the underlying issue