Apply type inheritance check

ppy · Dec 19, 2024 · c7354d9 · c7354d9
1 parent 239dc7d
commit c7354d9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/osu.Game/IO/Serialization/Converters/TypedListConverter.cs b/osu.Game/IO/Serialization/Converters/TypedListConverter.cs
@@ -62,8 +62,12 @@ public override IReadOnlyList<T> ReadJson(JsonReader reader, Type objectType, IR
                 if (tok["$type"] == null)
                     throw new JsonException("Expected $type token.");
 
-                string typeName = lookupTable[(int)tok["$type"]];
-                var instance = (T)Activator.CreateInstance(Type.GetType(typeName).AsNonNull())!;
+                // Prevent instantiation of types that do not inherit the type targetted by this converter
+                Type type = Type.GetType(lookupTable[(int)tok["$type"]]).AsNonNull();
+                if (!type.IsAssignableTo(typeof(T)))
+                    continue;
+
+                var instance = (T)Activator.CreateInstance(type)!;
                 serializer.Populate(itemReader, instance);
 
                 list.Add(instance);