Skip to content

Commit

Permalink
Revert to previous bound in drum roll tick generation
Browse files Browse the repository at this point in the history
While `EndTime + tickSpacing` _was_ closer to what stable was using, it
could cause undesirable edge cases wherein a tick would be spawned
outside of the drum roll's duration
(see https://github.com/ppy/osu/pull/23768/files#r1222073027).

For this reason, stick with the old code for now, as it is not as
susceptible to that sort of breakage.
  • Loading branch information
bdach authored and peppy committed Jun 9, 2023
1 parent fd8e77d commit 8962cba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Taiko/Objects/DrumRoll.cs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ private void createTicks(CancellationToken cancellationToken)

bool first = true;

for (double t = StartTime; t < EndTime + tickSpacing; t += tickSpacing)
for (double t = StartTime; t < EndTime + tickSpacing / 2; t += tickSpacing)
{
cancellationToken.ThrowIfCancellationRequested();

Expand Down

0 comments on commit 8962cba

Please sign in to comment.