Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the upload release asset github workflow #720

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

carmal891
Copy link
Contributor

What this PR does / why we need it:
Fixes issue #712

  • Uses build matrix
  • Mitigates warnings due to deprecated commands

Reference run - https://github.com/carmal891/pvsadm/actions/runs/12789761712

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes issue #712

Special notes for your reviewer:

  • In the previous release, a tarball containing all binaries (all OS and architecture combinations) was included as a release asset. Removed this because it doesn't provide much value, each binary is already uploaded as a separate release asset packaged with its respective OS and architecture. Verified via global search to ensure tarball containing all binaries is not used in code elsewhere.

**Output/Demonstration


@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2025
@mkumatag
Copy link
Member

/cc @kishen-v

@ppc64le-cloud ppc64le-cloud deleted a comment from Sopheap-cloud Jan 16, 2025
@kishen-v kishen-v changed the title modernize the upload release asset github workflow Modernize the upload release asset github workflow Jan 16, 2025
@carmal891 carmal891 requested a review from kishen-v January 17, 2025 08:17
@kishen-v kishen-v added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2025
@kishen-v
Copy link
Contributor

kishen-v commented Jan 18, 2025

Thank you @carmal891.
/lgtm
/cc @mkumatag for approval/final review.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carmal891, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 4f3618d into ppc64le-cloud:main Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mitigate deprecation/disablement warnings under Upload release asset workflow.
4 participants