Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce capture destination option #271

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mkumatag
Copy link
Member

This PR supports the different options for capture destinations

following new field is been added to the capture filed

destination (string) - The destination determines how the image is captured. Options: ('image-catalog', 'cloud-storage', 'both'). The default is 'cloud-storage'.
if image-catalog is specified then cos field content will be ignored

e.g:

....
    "builders": [
        {
            "type": "powervs",
....
.....
            "capture": {
                "name": "target-image-1",
                "destination": "image-catalog"
            }
        }
    ],
.....

post this run, you will see something like below:

$ ibmcloud pi image ls
ID                                     Name              Address
85c30fc5-2d25-4b40-95b5-932201bacc65   CentOS-Stream-9   /pcloud/v1/cloud-instances/e943af9c58c04143a7035c52b6d27c16/images/85c30fc5-2d25-4b40-95b5-932201bacc65
f1eb1728-72e9-4b2f-9a01-62756a264d56   target-image-1    /pcloud/v1/cloud-instances/e943af9c58c04143a7035c52b6d27c16/images/f1eb1728-72e9-4b2f-9a01-62756a264d56

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@mkumatag mkumatag added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit d4dc7be into ppc64le-cloud:main Jan 23, 2025
19 checks passed
@mkumatag mkumatag deleted the cap_destination branch January 23, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants