Allow passing several subnets for vm creation #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le-cloud-bot
added
the
do-not-merge/invalid-commit-message
|
Welcome @fernflower! It looks like this is your first PR to ppc64le-cloud/packer-plugin-powervs 🎉 |
ppc64le-cloud-bot
added
the
size/M
fernflower
force-pushed
the
supportsubnets
branch
from
ed932aa to
d82eb4c
Compare
ppc64le-cloud-bot
removed
the
do-not-merge/invalid-commit-message
Previously only one user-defined subnet was supported which proved to be not enough for some tricky cases. This patch will allow specifying comma-separated list of subnets in the template, ex. subnet_ids: "969ef856-27e9-4255-ae9e-61b1a7bb6e2f,7233c9d2-aac8-41b5-8d3d-264eb2a57287" The address from the first specified subnet will be used to connect to the machine via ssh.
fernflower
force-pushed
the
supportsubnets
branch
from
d82eb4c to
bc4b555
Compare
mkumatag
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fernflower, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only one user-defined subnet was supported which proved to be not enough for some tricky cases.
This patch will allow specifying comma-separated list of subnets in the template, ex.
subnet_ids: "969ef856-27e9-4255-ae9e-61b1a7bb6e2f,7233c9d2-aac8-41b5-8d3d-264eb2a57287"
The address from the first specified subnet will be used to connect to the machine via ssh.
Closes: #264