Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable CI #244

wants to merge 1 commit into from

Conversation

AshwinHIBM
Copy link
Collaborator

No description provided.

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
@clnperez
Copy link
Collaborator

clnperez commented Dec 9, 2024

looks simple enough. where does the prow job config live? i should probably take another look at that as well to refresh my memory

@AshwinHIBM
Copy link
Collaborator Author

looks simple enough. where does the prow job config live? i should probably take another look at that as well to refresh my memory

Sure, it's in a PR: ppc64le-cloud/test-infra#517

@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2025
clnperez
clnperez requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@clnperez clnperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add more detail to the title, summary, and git commit?

setup-pj-trigger.sh
@@ -0,0 +1,25 @@
#!/bin/bash

echo "Triggering the next prow job using git commit"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you include a bit more detail here about where the commit is to? this repo? which file?

setup-pj-trigger.sh
while getopts ":r:" option; do
case "${option}" in
r)
TRACKING_REPO=${OPTARG}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's OPTARG here?

upstream-master-ci/prow-info-docker.sh
./setup-pj-trigger.sh -r ppc64le-cloud/docker-ce-build
else
echo "The kernel is not suitable to run Docker."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this error message really the only possible explanation we could get back a non-zero rc from info.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clnperez clnperez clnperez requested changes

@Jenkins-J Jenkins-J Awaiting requested review from Jenkins-J

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshwinHIBM @ppc64le-cloud-bot @clnperez