Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent subnetworks in network-area diagrams #669

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

quinarygio
Copy link
Contributor

@quinarygio quinarygio commented Jan 20, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #611

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@quinarygio quinarygio marked this pull request as draft January 20, 2025 16:51
Signed-off-by: Giovanni Ferrari <[email protected]>
Signed-off-by: Giovanni Ferrari <[email protected]>
@quinarygio quinarygio marked this pull request as ready for review January 21, 2025 11:55
@So-Fras
Copy link
Member

So-Fras commented Jan 24, 2025

Thanks for the work!

As discussed together:

  • It was not mentioned in the issue but it would be great if users could choose whether or not they want to highlight subnetworks. Maybe, via a new SvgParameters boolean attribute? The SvgWriter has already access to the SvgParameters. There can be a if condition using this new SvgParameters boolean that would trigger the duplication of lines and nodes (or not). Furthermore, this way, all the duplicated parts would be grouped together in the svg.

  • The Graph should not be the object to hold information on style (it's only nodes and edges) --> the NetworkGraphBuilder class should not be affected by this PR

  • The StyleProvider "family" should be the one affected by the PR. In the if condition in the SvgWriter mentioned above, we would call a new specific method of the StyleProvider for highlight. Thus, the StyleProvider does not need to "know" whether the user wants to highlight something or not.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
86.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Represent subnetworks in network-area diagrams
2 participants