Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google/ClientId #34

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Google/ClientId #34

merged 4 commits into from
Dec 9, 2024

Conversation

borut-t
Copy link
Collaborator

@borut-t borut-t commented Nov 15, 2024

We need to provide clientId when authenticating via Firebase.

@borut-t borut-t requested review from EgzonArifi, yllfejziu, a team and tonikocjan November 15, 2024 14:02
@borut-t @EgzonArifi
Typo
c7fd0e5 
Co-authored-by: Egzon Arifi <[email protected]>
@borut-t borut-t requested a review from EgzonArifi December 9, 2024 13:48
@EgzonArifi
Copy link
Member

@borut-t can you check the tests pls?

@borut-t borut-t merged commit 0b0562c into develop Dec 9, 2024
1 check passed
@borut-t borut-t deleted the google/additional-metadata branch December 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagavcindriqim nagavcindriqim nagavcindriqim approved these changes

@markom-povio markom-povio markom-povio approved these changes

@EgzonArifi EgzonArifi EgzonArifi approved these changes

@yllfejziu yllfejziu Awaiting requested review from yllfejziu

@tonikocjan tonikocjan Awaiting requested review from tonikocjan

Assignees
No one assigned
Labels
rebase squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@borut-t @EgzonArifi @markom-povio @nagavcindriqim