Drag drop and loader #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 5074a76 into 59594e7 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
poush
reviewed
Oct 25, 2018
| * Gracefully accepting constructive criticism | ||
| * Focusing on what is best for the community | ||
| * Showing empathy towards other community members | ||
| - Using welcoming and inclusive language |
There was a problem hiding this comment.
This changes even if required should be performed in separate PR. Let's keep the changes which are mainly for the issue.
poush
reviewed
Oct 25, 2018
| @@ -1,8 +1,6 @@ | |||
| CC0 1.0 Universal | |||
| ================== | |||
| # CC0 1.0 Universal | |||
There was a problem hiding this comment.
It's just the "Markdown" extension on visual studio code.
poush
reviewed
Nov 3, 2018
README.md
Outdated
| ## Credits | ||
|
|
||
| | Contributor | Name | | |
There was a problem hiding this comment.
I would prefer this to be present is a separate file like "contributors.md" which can be linked here.
To be added as a separate file.
poush
approved these changes
Nov 3, 2018
|
This pull request introduces 1 alert when merging 58998a8 into 59594e7 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
Thank you! |
poush
pushed a commit
that referenced
this pull request
Nov 10, 2018
* Drag&Drop + Loader * Edit Readme * Remove redundant code * Remove redundant code * Remove contributors section To be added as a separate file.
poush
pushed a commit
that referenced
this pull request
Nov 10, 2018
* Drag&Drop + Loader * Edit Readme * Remove redundant code * Remove redundant code * Remove contributors section To be added as a separate file.
poush
pushed a commit
that referenced
this pull request
Nov 10, 2018
* Drag&Drop + Loader * Edit Readme * Remove redundant code * Remove redundant code * Remove contributors section To be added as a separate file.
poush
pushed a commit
that referenced
this pull request
Nov 10, 2018
* Drag&Drop + Loader * Edit Readme * Remove redundant code * Remove redundant code * Remove contributors section To be added as a separate file.
poush
pushed a commit
that referenced
this pull request
Nov 10, 2018
* Drag&Drop + Loader * Edit Readme * Remove redundant code * Remove redundant code * Remove contributors section To be added as a separate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature: #12 (PR #22)
Added a number of things:
Image editor demo:
Go back to H2 homepage:
Using the loader elsewhere:
Change 'YOUR_QUERY_SELECTOR' to the element that needs to exist before removing loading spinner. If element doesn't appear in 10 seconds, waitForLoader throws an error. You can create alternative spinners, just add the css and create your element with the ID 'loading'. Once the element exists, element with ID 'loading' is removed.
Example:
let loader = document.createElement("div");loader.setAttribute("id", "loading");loader.setAttribute("class", "loading");loader.innerHTML = "Loading…";document.body.appendChild(loader);waitForLoader("YOUR_QUERY_SELECTOR").then(res => {// Remove spinner once the element exists in DOM.document.getElementById("loading").remove();}).catch(err => {// 10 seconds has passed and element doesn't exists});Loader demo:
