Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag and drop feature for local files #12

Closed
poush opened this issue Sep 6, 2018 · 6 comments
Closed

Add drag and drop feature for local files #12

poush opened this issue Sep 6, 2018 · 6 comments

Comments

@poush
Copy link
Owner

poush commented Sep 6, 2018

It should support only certain file types. Allowing people to drag and drop it to the app to view it in picture in picture mode.

@poush
Copy link
Owner Author

poush commented Sep 6, 2018

This also adds the question of adding the dock icon back for macOS or not. Adding back will allow us to drop into the dock icon as well which is used by mac people most of the time when they drag any file to apps.

@gloriousducks
Copy link
Contributor

gloriousducks commented Oct 5, 2018

Just submitted a PR.

demo-h2

I have a bunch of new cool UI/UX stuff to add to this project.

@poush
Copy link
Owner Author

poush commented Oct 14, 2018

@rouzbehhz no hurries, just wanted if you are currently working on re-submitting that PR because I have one idea on this. Actually, we can rather directly connecting it with a specific feature, connect it with the providers module. Thus, if anyone drags any file which will call providers with the local URI. Providers on matching it with the respective provider of that URI will fire proper event in renderer process to process it. We can definitely work on this in new PR and issue.

@gloriousducks
Copy link
Contributor

@poush Yes, out cold last few days. Going to add this in sometime today or tomorrow, have a bunch of stuff from work I have to catch up on. Also added a nice app navigation and landing page I can include in the PR (Issue #24) if you want to wait on it.

Cheers

@poush
Copy link
Owner Author

poush commented Oct 18, 2018

Sure, no issues.

@poush
Copy link
Owner Author

poush commented Nov 9, 2018

Thanks @rouzbehhz. I hope to see further contributions to providers standardization :)

@poush poush closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants