-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more, hopefully rather uncontroversial simplifications #172
base: master
Are you sure you want to change the base?
Conversation
@ZachJHansen You can review and merge this whenever you like. I do not indent to add more to this. All other simplifications will go into other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, except I would prefer that each change in apply_definitions be a separate function so we can choose to apply them independently. Also, it would be nice to support a transformation from "F -> #false" to "not F" as well.
We discussed in today's joint meeting:
|
3aab5de
to
f176fdc
Compare
This is the first follow-up for #164. It groups all the "easy" and therefore rather "uncontroversial" simplifications.