Upgrade webR to v0.2.2 and load R Shiny package from filesystem image #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgestagg
force-pushed
the
webr-shiny-image
branch
from
6a770f7 to
cac831a
Compare
This does not matter much for this particular URL, but I hit an issue when experimenting where I had not realised a 404 HTML page had been downloaded and placed into the shinylive source tree.
Download the webR shiny image during build, and load the image into webR when launching R Shiny apps. Also includes minor fixes to error reporting and formatting.
Squelches a non-useful user-facing error message when a Shiny app has been interrupted but a HTTP request is still in progress in the app iframe.
georgestagg
force-pushed
the
webr-shiny-image
branch
from
cac831a to
4eacfeb
Compare
wch
approved these changes
Nov 27, 2023
This was referenced Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor bug fixes and formatting updates from prettier.