Integration Flakey Test Fixes #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
I ran it several times and it's still failing occasionally with nothing in the Connect logs: |
|
Github also had several issues today so maybe that's a factor: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Intergration Tests have been flakey lately. The first issue was, the docker container wasn't getting the RSC_LICENSE variable for Connect so Connect never started.
Like here:
https://github.com/rstudio/rsconnect-python/actions/runs/8567414234/job/23488396171#step:6:12
I moved the
RSC_LICENSEvariable up in the Github Actions workflow and that seems to have solved the license issue. However, I still saw some race conditions where the test would start before Connect was ready, so I added a script to wait for Connect to start. There were also some warnings about password security when the users were being created, so I updated those as well.