Fix CI #1830
Merged
Fix CI #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Jan 28, 2025
| @@ -251,7 +251,6 @@ async def process_request( | |||
| status_code=http.HTTPStatus.MOVED_PERMANENTLY, | |||
| reason_phrase="Moved Permanently", | |||
| headers=websockets.Headers(Location=app_url), | |||
| body=None, | |||
There was a problem hiding this comment.
The type for body recently went from bytes | None to bytes
python-websockets/websockets@e6d0ea1
It seems we've always just wanted the default value for body anyway, so this seems safe to remove
gadenbuie
reviewed
Jan 29, 2025
gadenbuie
approved these changes
Jan 29, 2025
Co-authored-by: Garrick Aden-Buie <[email protected]>
|
One of the deploy tests is still failing, and I'm not quite sure why. I manually checked the deployed app and everything seems to be working OK, so I'm gonna merge this since there are other important fixes here. cc @karangattu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1829