bug(input_text_area): Auto resized text areas resize on visibility change #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Jul 25, 2024
cpsievert
reviewed
Jul 25, 2024
cpsievert
reviewed
Jul 25, 2024
cpsievert
reviewed
Jul 25, 2024
cpsievert
reviewed
Jul 25, 2024
Co-authored-by: Carson Sievert <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Jul 26, 2024
* main: bug(input_text_area): Auto resized text areas resize on visibility change (posit-dev#1569) chore(ci): Skip all chat tests on webkit (posit-dev#1575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://discord.com/channels/1109483223987277844/1265694689378697227/1266038169053171712
When the input text area would be displayed after an accordion expanded or a new tab was displayed, the text area would have height of 0 as the original scroll height was 0 (as it was hidden).
Now, if the scroll height is 0 an intersection observer is used until the text area is slightly on screen, then we update the height. To signal that we should perform this default behavior, a value of
rows=0is used. This is not a possible value, so.getAttribute("rows")must be used to check for the0value. (Otherwise,target.rowswill return 2, the default value.)