Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version in the UI inside the AppMenu #904

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

dotNomad
Copy link
Collaborator

This PR re-adds the AppMenu to the VSCode extension view, keeps the dark mode menu items hidden, and shows the __VERSION__ in the last menu item.

Intent

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Directions for Reviewers

Check that in dev mode and production mode the version appears. Check that the VSCode extension view still does not have dark mode menu items in the AppMenu.

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Verified functionality, version shown matches build version (although I had to restart my vite server in order to see it, but this was expected):

2024-01-29 at 11 09 AM

Base automatically changed from dotnomad/ui-version to main January 29, 2024 19:14
@dotNomad dotNomad merged commit 88bee68 into main Jan 29, 2024
22 checks passed
@dotNomad dotNomad deleted the dotnomad/version-in-ui branch January 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Version in the dropdown menu of the UI
2 participants