Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude debug log messages from deploy steps #887

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mmarchetti
Copy link
Contributor

Intent

The PR filters frontend event display in the Summarized Log panel so that it excludes debug log messages.

Fixes #871

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

Filtered this in the frontend, at the view level. We wanted to keep those events from the backend for a potential log display panel.

Directions for Reviewers

Review PR with diff whitespace turned off.

Deploy, and see that the "API request" debug messages are no longer present in the summary log view (for example, expand the preflight step which had several in a row).

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you consider reverting your changes and implementing the simpler approach suggestion that I provided. I also considered filtering within the code which was receiving the events and not adding them into the event store, but I think you made a good decision to implement the filtering within the presentation layer rather than within the plumbing.

web/src/views/deploy-progress/DeployStep.vue Show resolved Hide resolved
Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at it closer, you were absolutely correct with your original approach. I would like to refactor the logic within this component to simplify it, but I think your approach to hiding the debug log messages works great. Thanks so much!

@mmarchetti mmarchetti marked this pull request as ready for review January 26, 2024 19:37
@mmarchetti mmarchetti merged commit 6840c84 into main Jan 26, 2024
22 checks passed
@mmarchetti mmarchetti deleted the mm-remove-debug-logs-from-ui branch January 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop showing debug log messages in the UI
2 participants