build: adds tooling for uploading to object storage #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdstein
force-pushed
the
tdstein/524
branch
6 times, most recently
from
9f32e44 to
340856a
Compare
tdstein
requested review from
dotNomad,
kgartland-rstudio,
mmarchetti and
sagerb
as code owners
mmarchetti
approved these changes
Jan 29, 2024
| @@ -24,6 +24,12 @@ jobs: | |||
| archive: | |||
| needs: build | |||
| uses: ./.github/workflows/archive.yaml | |||
| upload: | |||
There was a problem hiding this comment.
Do we want to do this for PR branches, or is this temporary to test this PR?
There was a problem hiding this comment.
It's a bit of both. If we don't want to save pull-request builds, we can delete it.
dotNomad
reviewed
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Adds build tooling for uploading to S3 (CDN).
Resolves #524
Type of Change
Approach
Adds the command
just upload, which uploads build artifacts to S3 when available. The object location is derived from the GITHUB_REF (there is a link in the code documentation).Automated Tests
Directions for Reviewers
Checklist