Use the same structure and spacing for deployment summaries #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
commented
Jan 14, 2025
| } | ||
|
|
||
| .deployment-summary-container { | ||
| display: flex; | ||
| align-items: center; |
There was a problem hiding this comment.
This wasn't being used since align-items: baseline underneath overrode it.
| @@ -596,7 +598,8 @@ const viewContent = () => { | |||
| margin-top: 1.33em; | |||
| } | |||
|
|
|||
| .deployment-summary { | |||
| .deployment-summary-title { | |||
| margin-block-start: 1.33em; | |||
There was a problem hiding this comment.
This was pulled out of the user stylesheet of VS Code to unify it with .progress-ring
Comment on lines
+656
to
+657
| margin-top: 0; | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
The margin-top is now taken care of by the margin-bottom of the h4.deployment-summary-title CSS.
dotNomad
force-pushed
the
dotnomad/stages-same-height
branch
from
34e62c8 to
bb6c147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the structure and CSS of the in progress summary to be more similar to our other states - cancelled, successful, failed.
It unifies some of the CSS and markup to accomplish this so the vertical spacing and font-weight do not change across those summaries.
Preview Video
CleanShot.2025-01-14.at.13.51.22.mp4
Notice how the vertical space between the title (progress ring) and the line above no longer change.
Intent
Resolves #2531
Type of Change