Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-on for dismissed deployment support PR #2524

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Follow-on for dismissed deployment support PR #2524

merged 11 commits into from
Jan 15, 2025

Conversation

sagerb
Copy link
Collaborator

@sagerb sagerb commented Jan 10, 2025

Intent

Resolves: #2179

This PR contains follow-on changes to #2522. These changes have been separated in order to facilitate reviews in progress.

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

The changes contained within this PR are:

  1. Unit tests have been added for the POST /deployments/{name}/cancel/{localid} API
  2. A problem found by the unit tests has been resolved with a small fix.
  3. The Publisher Log UX has been updated to indicate that a canceled deployment has been canceled rather than failed.
  4. A global search/replace has been done for the spelling of "cancelled" -> "canceled"

User Impact

The publisher log now looks like this when the deployment has been canceled:
2025-01-10 at 12 12 PM

Automated Tests

Added unit test for API, validating the expected behavior for success and 404.

Directions for Reviewers

Checklist

@sagerb
Update to publisher log display, unit tests on cancel API (with small…
21c0b1e 
… fix) and spelling change of "cancelling" to "canceling"
@sagerb sagerb self-assigned this Jan 10, 2025
@sagerb
remove flash of success status when canceling a deployment. Also fixe…
f00ecce 
…d filtering to include some log messages from connect which had the local ID value in snake_case rather than camelCase
dotNomad
dotNomad requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple questions on this one, plus the issue with changing a vendor file.

vendor/github.com/godbus/dbus/v5/conn.go Outdated Show resolved Hide resolved
internal/publish/publish.go Show resolved Hide resolved
internal/services/api/deployment_dto.go Outdated Show resolved Hide resolved
@sagerb
Copy link
Collaborator Author

sagerb commented Jan 13, 2025

Changes requested have been committed @dotNomad .

@sagerb sagerb requested a review from dotNomad January 13, 2025 19:47
dotNomad
dotNomad approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes. Looking good 😎

@sagerb sagerb merged commit 0376c4d into sagerb-support-dismissed-deployment Jan 15, 2025
13 of 14 checks passed
@sagerb sagerb deleted the sagerb-support-dismissed-deployment-follow-on branch January 15, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotNomad dotNomad dotNomad approved these changes

@marcosnav marcosnav Awaiting requested review from marcosnav marcosnav is a code owner

Assignees

@sagerb sagerb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagerb @dotNomad