Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR feedback for credentials reset #2512

Merged
merged 5 commits into from
Jan 7, 2025
Merged

PR feedback for credentials reset #2512

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee06425
Add TypeScript type for credentials reset
dotNomad Jan 6, 2025
e4ee098
Remove duplicate code in agent err resolution
dotNomad Jan 6, 2025
468a66e
Rename credentialstest file to include mock_
dotNomad Jan 6, 2025
167db78
Use credentials.list() after reset
dotNomad Jan 6, 2025
667ac3c
Mock empty list response after credentials reset
dotNomad Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/vscode/src/api/resources/Credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class Credentials {
// 204 - success (no response)
// 503 - credentials service unavailable
reset() {
return this.client.delete(`credentials`);
return this.client.delete<{ backupFile: string }>(`credentials`);
}

// Returns:
Expand Down
6 changes: 0 additions & 6 deletions extensions/vscode/src/utils/errorTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,5 @@ export function resolveAgentJsonErrorMsg(err: axiosErrorWithJson) {
return errPythonExecNotFoundErrorMessage(err);
}

// Ignore errors coming from credentials being reset,
// a warning is shown when PublisherState is updated.
if (isErrPythonExecNotFoundError(err)) {
return errPythonExecNotFoundErrorMessage(err);
}

return errUnknownMessage(err as axiosErrorWithJson<ErrUnknown>);
}
Loading