Add TreeSection actions container styling
#1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
dotNomad
commented
Apr 17, 2024
| :class="{ expanded: expanded }" | ||
| @click="expanded = !expanded" | ||
| @keydown.enter.self="toggleExpanded" |
There was a problem hiding this comment.
This makes it so ONLY the pane-header listens for keydown.enter otherwise focus on the children would have caused the toggle.
dotNomad
commented
Apr 17, 2024
| :class="expanded ? 'codicon-chevron-down' : 'codicon-chevron-right'" | ||
| /> | ||
| <h3 class="title">{{ title }}</h3> | ||
| <div class="pane-header-title-container" @click="toggleExpanded"> |
There was a problem hiding this comment.
Created this, and used justify-content: space-between to better handle toggleExpanded in Vue.
This is not how VSCode structures the DOM or styles it, but it looks and behaves functionality the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more functionality and styling to the
TreeSection:actionscontainer to place icons (currently hardcoded with one)@clickhandling to the title only so clicking on an action doesn't causeexpandedto be toggledTreeSectionwhen it is focused, andenteris pressedPreview Video
CleanShot.2024-04-17.at.16.05.54.mp4
Intent
Part of #1333
Type of Change