Use Dockerfile to build image #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgartland-rstudio
requested review from
dotNomad,
mmarchetti,
sagerb and
tdstein
as code owners
dotNomad
approved these changes
Apr 17, 2024
justfile
Outdated
| @@ -34,6 +34,9 @@ _uid_args := if os_family() == "unix" { | |||
| "" | |||
| } | |||
|
|
|||
| PYTHON_VESION := env("PYTHON_VESION", "3.12.1") | |||
There was a problem hiding this comment.
Suggested change
| PYTHON_VESION := env("PYTHON_VESION", "3.12.1") | |
| PYTHON_VERSION := env("PYTHON_VERSION", "3.12.1") |
There was a problem hiding this comment.
Thanks! I'll fix it.
mmarchetti
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
CI was broken by an upstream change to the docker container we rely on. This PR allows us to control the versions of Python and Quarto we want to use so we won't be broken by future changes.
Type of Change
Approach
Automated Tests
Directions for Reviewers
Checklist