Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate lint GitHub workflow #1183

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: lint
on: [pull_request]
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: extractions/setup-just@v2
- uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- run: just vscode lint
- run: just vscode check-format
2 changes: 2 additions & 0 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ concurrency:
group: ${{ github.head_ref }}
cancel-in-progress: true
jobs:
# lint:
# uses: ./.github/workflows/lint.yaml
# Unit Tests
agent:
uses: ./.github/workflows/agent.yaml
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/vscode.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ jobs:
path: ./extensions/vscode/.vscode-test/vscode-*
key: ${{ matrix.runner }}-vscode-${{ env.VSCODE_VERSION }}-${{ steps.get-date.outputs.date }}
- run: just vscode configure
- run: just vscode lint
- run: just vscode check-format
- run: just vscode test
- uses: actions/cache/save@v3
if: steps.cache.outputs.cache-hit != 'true'
Expand All @@ -53,8 +51,6 @@ jobs:
path: ./extensions/vscode/.vscode-test/vscode-*
key: docker-vscode-${{ env.VSCODE_VERSION }}-${{ steps.get-date.outputs.date }}
- run: just vscode configure
- run: just vscode lint
- run: just vscode check-format
- run: just vscode test
- uses: actions/cache/save@v3
if: steps.cache.outputs.cache-hit != 'true'
Expand Down
12 changes: 0 additions & 12 deletions extensions/vscode/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -98,24 +98,12 @@ install os="$(just ../../os)" arch="$(just ../../arch)" editor="code":

# Performs static code analysis with ESLint
lint:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}

npm run lint

format:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}

npm run format

check-format:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}

npm run check-format

# Packages the extension.
Expand Down
Loading