Merge pull request #2526 from posit-dev/dotnomad/last-deploy-alert

Update design for last deployment alerts
posit-dev · Jan 14, 2025 · bcabf8f · bcabf8f
2 parents f8dbf93 + 3d41c96
commit bcabf8f
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 8 deletions.
diff --git a/extensions/vscode/webviews/homeView/src/components/EvenEasierDeploy.vue b/extensions/vscode/webviews/homeView/src/components/EvenEasierDeploy.vue
@@ -185,7 +185,9 @@
           v-if="home.selectedContentRecord.deploymentError"
           class="last-deployment-details last-deployment-error"
         >
-          <span class="codicon codicon-alert"></span>
+          <div class="alert-border border-warning text-warning">
+            <span class="codicon codicon-alert" />
+          </div>
           <TextStringWithAnchor
             :message="home.selectedContentRecord?.deploymentError?.msg"
             :splitOptions="ErrorMessageSplitOptions"
@@ -607,11 +609,17 @@ const viewContent = () => {
 }
 
 .last-deployment-error {
-  border: solid 2px;
-  border-color: gray;
-  padding: 5px;
   display: flex;
-  align-items: center;
+  align-items: stretch;
+
+  .alert-border {
+    display: flex;
+    align-items: center;
+    border-right-width: 1px;
+    border-right-style: solid;
+    padding-right: 5px;
+    margin-right: 7px;
+  }
 }
 
 .error-icon {
@@ -621,7 +629,6 @@ const viewContent = () => {
 .error-message {
   min-width: 0;
   word-wrap: break-word;
-  margin-left: 5px;
 }
 
 .progress-container {

diff --git a/extensions/vscode/webviews/homeView/src/style.css b/extensions/vscode/webviews/homeView/src/style.css
@@ -50,10 +50,22 @@ body {
   color: var(--vscode-sideBarSectionHeader-foreground);
 }
 
+.text-warning {
+  color: var(--vscode-list-warningForeground);
+}
+
+.border-warning {
+  border-color: var(--vscode-list-warningForeground);
+}
+
 .text-error {
   color: var(--vscode-list-errorForeground);
 }
 
+.border-error {
+  border-color: var(--vscode-list-errorForeground);
+}
+
 .text-git-added {
   color: var(--vscode-gitDecoration-addedResourceForeground);
 }

diff --git a/extensions/vscode/webviews/homeView/vite.config.ts b/extensions/vscode/webviews/homeView/vite.config.ts
@@ -41,9 +41,9 @@ export default defineConfig({
       enabled: true,
       thresholds: {
         functions: 30.13,
-        lines: 17.48,
+        lines: 17.46,
         branches: 44.82,
-        statements: 17.48,
+        statements: 17.46,
         autoUpdate: true,
       },
     },