Merge pull request #2185 from posit-dev/sagerb-fix-path-for-edit-conf…

…iguration-on-windows Switch to properly use `Uri.file()` rather than `Uri.parse()`.
posit-dev · Aug 28, 2024 · 71c238a · 71c238a
2 parents 6f10801 + 986359b
commit 71c238a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/extensions/vscode/src/utils/files.ts b/extensions/vscode/src/utils/files.ts
@@ -79,7 +79,7 @@ export async function openNewOrExistingFileInPreview(
   appendedContents?: string,
 ) {
   let fileExist = true;
-  const existingUri = Uri.parse(filePath);
+  const existingUri = Uri.file(filePath);
   const newUri = Uri.file(filePath).with({ scheme: "untitled" });
 
   try {
@@ -123,7 +123,7 @@ export async function updateNewOrExistingFile(
   openEditor = false,
 ) {
   let fileExist = true;
-  const uri = Uri.parse(filePath);
+  const uri = Uri.file(filePath);
 
   try {
     await workspace.fs.stat(uri);
@@ -263,7 +263,7 @@ export function relativePath(uri: Uri): string | undefined {
     return undefined;
   }
   const base = uriUtils.basename(uri);
-  const relativeFilePath = uriUtils.joinPath(Uri.parse(relativeDirPath), base);
+  const relativeFilePath = uriUtils.joinPath(Uri.file(relativeDirPath), base);
   let result = relativeFilePath.path;
   if (result.startsWith(path.sep)) {
     result = result.replace(path.sep, "");

diff --git a/extensions/vscode/src/views/homeView.ts b/extensions/vscode/src/views/homeView.ts
@@ -1666,7 +1666,7 @@ export class HomeViewProvider implements WebviewViewProvider, Disposable {
           if (config) {
             return await commands.executeCommand(
               "vscode.open",
-              Uri.parse(config.configurationPath),
+              Uri.file(config.configurationPath),
             );
           }
           console.error(